Messages in this thread | | | Date | Mon, 22 Oct 2012 20:34:53 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN for PF_NOFREEZE or PF_FREEZER_SKIP tasks |
| |
On 10/16, Tejun Heo wrote: > > cgroup_freezer doesn't transition from FREEZING to FROZEN if the > cgroup contains PF_NOFREEZE tasks or tasks sleeping with > PF_FREEZER_SKIP set.
And thus the patch looks like another bugfix to me.
Just one question, and this question is offtopic again,
> Only kernel tasks can be non-freezable (PF_NOFREEZE)
Hmm. We seem to "leak" PF_NOFREEZE if a kernel thread execs? Perhaps do_execve_common() should do set_freezable() before return.
Or, at least, simply clear this flag along with PF_KTHREAD in flush_old_exec().
Oleg.
| |