Messages in this thread | | | From | Irina Tirdea <> | Date | Mon, 22 Oct 2012 12:06:08 +0300 | Subject | Re: [PATCH v4 3/6] perf tools: add --addr2line command line option |
| |
On Tue, Oct 16, 2012 at 6:21 PM, Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote: > Em Tue, Oct 16, 2012 at 02:33:37AM +0300, Irina Tirdea escreveu: >> From: Irina Tirdea <irina.tirdea@intel.com> >> >> When analyzing data recorded on a target with a different architecture >> than the host, we must use addr2line from the toolchain for that >> architecture. >> >> Add a command line option to allow setting addr2line at runtime. > > You're doing two things here: > > 1. Adding --addr2line > > 2. fixing a bug for unresolved symbols > > Please try not to do that, instead provide two patches, one addressing > each issue. >
You're absolutely right. Missed this.
> Furthermore, Namhyung fixed #2 already: > > commit a2c1311c4cbd47a087e95be18fee79ead3d0744b > Author: Namhyung Kim <namhyung.kim@lge.com> > Date: Mon Oct 15 12:39:42 2012 +0900 > > perf tools: Fix segfault when using srcline sort key > > - Arnaldo
Thanks, Irina
| |