lkml.org 
[lkml]   [2012]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/9] Staging: winbond: Fixed coding style issues
From
Hi Pavel,

On Sun, Oct 21, 2012 at 4:12 PM, Pavel Machek <pavel@ucw.cz> wrote:
> On Fri 2012-10-12 22:07:06, Adil Mujeeb wrote:
>>
>> winbond directory files have lots of coding style issues. The patch
> set tries to remove *most* (if not all) of the coding style
> issues. checkpatch.pl script is still complaining (like 80 characters
> limit) but major part of the serious coding style issues have been
> rectified.
>
> ACK on patches except 2 and 5. Plus if you could keep the printks,
> that would be great. When the driver is debugged and in wide use, we
> can remove them, but now they are useful...

Thanks Pavel for acknowledgement.

I removed printk's as Joe and Greg recommended to remove "tracing"
type debug calls. Let me know if I need to resubmit the patch.

Regards,
Adil

>
> Thanks,
> Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2012-10-21 14:01    [W:0.097 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site