Messages in this thread | | | From | Rusty Russell <> | Subject | Re: RFC: sign the modules at install time | Date | Mon, 22 Oct 2012 10:58:11 +1030 |
| |
Linus Torvalds <torvalds@linux-foundation.org> writes: > On Fri, Oct 19, 2012 at 12:58 PM, Linus Torvalds > <torvalds@linux-foundation.org> wrote: >> >> Tssk. I fixed it up, and now it works-for-me(tm), but some perl person >> probably really should try to make that sign-file and x509keyid merge. >> My fix made the thing even slower, doing two extra "wc -c" invocations >> since it can't do "${#..}" expansion due to the locale problem. > > Hmm. I haven't seen this breakage personally yet, but looking more at > Rusty's last changes I'm pretty sure my fixes are potentially not > sufficient.
Sorry for posting untested hack :(
Thanks for the rewrite David; modules_install here was 18.6 seconds, became 19.1 with my broken hack, now 17.3 seconds.
Cheers, Rusty.
| |