Messages in this thread | | | Date | Wed, 03 Oct 2012 10:33:29 +1000 | From | Ryan Mallon <> | Subject | Re: [PATCH 3/7] staging: rts_pstor: reuse kbasename() |
| |
On 03/10/12 10:30, Ryan Mallon wrote: > On 03/10/12 01:00, Andy Shevchenko wrote: >> The custom filename function mostly repeats the kernel's kbasename. This patch >> simplifies it. The updated filename() will not check for the '\' in the >> filenames. It seems redundant in Linux. >> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Cc: YAMANE Toshiaki <yamanetoshi@gmail.com> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> --- >> drivers/staging/rts_pstor/trace.h | 16 +++------------- >> 1 file changed, 3 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h >> index cf60a1b..59c5686 100644 >> --- a/drivers/staging/rts_pstor/trace.h >> +++ b/drivers/staging/rts_pstor/trace.h >> @@ -24,26 +24,16 @@ >> #ifndef __REALTEK_RTSX_TRACE_H >> #define __REALTEK_RTSX_TRACE_H >> >> +#include <linux/string.h> >> + >> #define _MSG_TRACE >> >> #ifdef _MSG_TRACE >> static inline char *filename(char *path) >> { >> - char *ptr; >> - >> if (path == NULL) >> return NULL; >> - >> - ptr = path; >> - >> - while (*ptr != '\0') { >> - if ((*ptr == '\\') || (*ptr == '/')) >> - path = ptr + 1; > > The original version here returns the string after the last '/' or '\', > the new kbasename function only looks for '/'. Does that matter here, or > was the original code over eager?
Nevermind, I didn't read the changelog fully :-/.
~Ryan
| |