| Date | Tue, 2 Oct 2012 15:24:34 -0400 | From | Vivek Goyal <> | Subject | Re: [dm-devel] [PATCH v3 09/26] block: Remove bi_idx references |
| |
On Mon, Sep 24, 2012 at 03:34:49PM -0700, Kent Overstreet wrote:
[..] > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c > index 95e52879..24e5cef 100644 > --- a/drivers/block/floppy.c > +++ b/drivers/block/floppy.c > @@ -3778,7 +3778,6 @@ static int __floppy_read_block_0(struct block_device *bdev) > bio_vec.bv_len = size; > bio_vec.bv_offset = 0; > bio.bi_vcnt = 1; > - bio.bi_idx = 0;
So leaving bio.bi_idx uninitialized is safer than setting it to zero? Can you explain a bit more that why this change is required?
Thanks Vivek
|