Messages in this thread | | | Date | Tue, 02 Oct 2012 15:57:43 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [patch] x86/cache_info: use ARRAY_SIZE() in amd_l3_attrs() |
| |
On 10/02/2012 02:04 PM, Dan Carpenter wrote: > Using ARRAY_SIZE() is more readable. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards, Srivatsa S. Bhat
> diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c > index 9a7c90d..93c5451 100644 > --- a/arch/x86/kernel/cpu/intel_cacheinfo.c > +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c > @@ -991,7 +991,7 @@ static struct attribute ** __cpuinit amd_l3_attrs(void) > if (attrs) > return attrs; > > - n = sizeof (default_attrs) / sizeof (struct attribute *); > + n = ARRAY_SIZE(default_attrs); > > if (amd_nb_has_feature(AMD_NB_L3_INDEX_DISABLE)) > n += 2; >
| |