Messages in this thread | | | From | KOSAKI Motohiro <> | Date | Fri, 19 Oct 2012 02:53:56 -0400 | Subject | Re: [PATCH v3 2/9] suppress "Device nodeX does not have a release() function" warning |
| |
On Fri, Oct 19, 2012 at 2:46 AM, <wency@cn.fujitsu.com> wrote: > From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > > When calling unregister_node(), the function shows following message at > device_release(). > > "Device 'node2' does not have a release() function, it is broken and must > be fixed." > > The reason is node's device struct does not have a release() function. > > So the patch registers node_device_release() to the device's release() > function for suppressing the warning message. Additionally, the patch adds > memset() to initialize a node struct into register_node(). Because the node > struct is part of node_devices[] array and it cannot be freed by > node_device_release(). So if system reuses the node struct, it has a garbage. > > CC: David Rientjes <rientjes@google.com> > CC: Jiang Liu <liuj97@gmail.com> > Cc: Minchan Kim <minchan.kim@gmail.com> > CC: Andrew Morton <akpm@linux-foundation.org> > CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
I still think node array should be converted node pointer array and node_device_release() free memory as other typical drivers. However, this is acceptable as first step.
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| |