lkml.org 
[lkml]   [2012]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix
    On Mon, Oct 15, 2012 at 01:09:04PM -0700, Kent Overstreet wrote:
    > This adds a pointer to the bvec array to struct bio_integrity_payload,
    > instead of the bvecs always being inline; then the bvecs are allocated
    > with bvec_alloc_bs().
    >
    > This is needed eventually for immutable bio vecs - immutable bvecs
    > aren't useful if we still have to copy them, hence the need for the
    > pointer. Less code is always nice too, though.
    >
    > Also fix an amusing bug in bio_integrity_split() - struct bio_pair
    > doesn't have the integrity bvecs after the bio_integrity_payloads, so
    > there was a buffer overrun. The code was confusing pointers with arrays.

    Ummm... patch description doesn't agree with the patch content?

    --
    tejun


    \
     
     \ /
      Last update: 2012-10-19 23:01    [W:4.201 / U:2.468 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site