Messages in this thread | | | Date | Fri, 19 Oct 2012 18:07:25 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 1/2] perf tools: add event modifier to request exclusive PMU access |
| |
On Fri, Oct 19, 2012 at 08:46:10AM -0700, Andi Kleen wrote: > > That's what I thought too, but then I don't understand why it was at > > eight before and not > > seven: One instance of each letter, + a second for pp (precise=2). Or > > am I missing > > something here? > > The number is pretty useless imho (it's unlikely to catch any real user error) > and most likely generates a much longer automata in flex than just a + > So I would drop it.
yep, probably we could do better job with checking the modifier after parsing (with just + in flex) ... added in my todo ;)
jirka
| |