lkml.org 
[lkml]   [2012]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: reserve pins when states are activated
On 10/18/2012 04:01 AM, Linus Walleij wrote:
> This switches the way that pins are reserved for multiplexing:

The conceptual change makes perfect sense to me.

> diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c

> void pinmux_free_setting(struct pinctrl_setting const *setting)
...
> + /*
> + * If a setting is active, disable it so that all pins are released
> + */
> + pinmux_disable_setting(setting);

"*If* a setting is active ..." implies there should be a C if statement
here to check if the setting is actually active before trying to disable it?


\
 
 \ /
  Last update: 2012-10-19 04:01    [W:0.110 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site