Messages in this thread | | | Date | Thu, 18 Oct 2012 17:33:24 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH] pinctrl: reserve pins when states are activated |
| |
On 10/18/2012 04:01 AM, Linus Walleij wrote: > This switches the way that pins are reserved for multiplexing:
The conceptual change makes perfect sense to me.
> diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
> void pinmux_free_setting(struct pinctrl_setting const *setting) ... > + /* > + * If a setting is active, disable it so that all pins are released > + */ > + pinmux_disable_setting(setting);
"*If* a setting is active ..." implies there should be a C if statement here to check if the setting is actually active before trying to disable it?
| |