Messages in this thread | | | Subject | Re: [PATCH 00/23] printk: refactoring | From | Joe Perches <> | Date | Thu, 18 Oct 2012 17:43:17 -0700 |
| |
On Thu, 2012-10-18 at 16:16 -0700, Andrew Morton wrote: > On Tue, 16 Oct 2012 23:06:04 -0700 > Joe Perches <joe@perches.com> wrote: > > > Make printk a bit more readable. [] > OK, nobody's allowed to change the printk code for two months.
[filelist]
> It wouldn't hurt to describe the design here a bit. How was the code > partitioned and what is the role of each file?
Design? Have you looked at printk recently?
I think you called it something like "eye gouging" or maybe "burn it down".
Dunno how anyone could consider what there anything other than accreted.
I just tried to break it up into somewhat sensible blocks.
> That's reasonably obvious from the names, but some might wonder about > the difference between printk_log and printk_syslog and how that > division was decided upon.
None of the filenames are great.
I still want to break out the console code from what's left of printk.c eventually.
I think what would help most is a Documentation/printk.txt file explaining how it all works.
cheers, Joe
| |