Messages in this thread | | | Date | Thu, 18 Oct 2012 14:56:07 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts |
| |
On Wed, Oct 17, 2012 at 03:30:43PM +0200, Michal Hocko wrote: > mem_cgroup_force_empty did two separate things depending on free_all > parameter from the very beginning. It either reclaimed as many pages as > possible and moved the rest to the parent or just moved charges to the > parent. The first variant is used as memory.force_empty callback while > the later is used from the mem_cgroup_pre_destroy. > > The whole games around gotos are far from being nice and there is no > reason to keep those two functions inside one. Let's split them and > also move the responsibility for css reference counting to their callers > to make to code easier. > > This patch doesn't have any functional changes. > > Signed-off-by: Michal Hocko <mhocko@suse.cz>
Reviewed-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |