lkml.org 
[lkml]   [2012]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] module: add syscall to load module from fd
    On 10/18/2012 01:05 AM, Michael Kerrisk (man-pages) wrote:
    >>
    >> So perhaps what we *should* have is something that points to the module
    >> to a (buffer, length) in userspace, and the equivalent of the current
    >> init_module() would be open() + mmap() + minit_module() + close()?
    >
    > So, I don't get it. What are the args you propose for of minit_module()?
    >

    Nevermind, this is what the current init_module() already takes.

    So it sounds like Rusty is objecting to the very notion of tying a
    module to a file descriptor the way the proposed finit_module() system
    call does -- I was confused about the functioning of the *current*
    init_module() system call.

    Given that, I have to say I now seriously question the value of
    finit_module(). The kernel can trivially discover if the pointed-to
    memory area is a MAP_SHARED mmap() of a file descriptor and if so which
    file descriptor... why can't we handle this behind the scenes?

    -hpa

    P.S. the man page for init_module(2) is seriously out of date...

    --
    H. Peter Anvin, Intel Open Source Technology Center
    I work for Intel. I don't speak on their behalf.



    \
     
     \ /
      Last update: 2012-10-18 17:01    [W:7.150 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site