Messages in this thread | | | Subject | Re: [PATCH 3/3] power: wm831x_power.c: Fixed indentation bug and whitespace errors | From | Joe Perches <> | Date | Wed, 17 Oct 2012 08:39:43 -0700 |
| |
On Thu, 2012-10-18 at 00:01 +0900, Sangho Yi wrote: > I removed trailing whitespaces and removed unnecessary whitespaces and > indentation tabs. [] > diff --git a/drivers/power/wm831x_power.c b/drivers/power/wm831x_power.c [] > @@ -632,9 +632,8 @@ static __devexit int wm831x_power_remove(struct platform_device *pdev) > int irq, i; > > for (i = 0; i < ARRAY_SIZE(wm831x_bat_irqs); i++) { > - irq = wm831x_irq(wm831x,
There is a trailing space here...
> - platform_get_irq_byname(pdev, > - wm831x_bat_irqs[i]));
but there's nothing wrong with this.
> + irq = wm831x_irq(wm831x, platform_get_irq_byname(pdev, > + wm831x_bat_irqs[i]));
ugh.
If you're really going to do these sorts of changes just to minimize overall line length, please keep arguments aligned on parentheses where appropriate.
Maybe use a temporary if you're really concerned about overall line length.
for (i = 0; i < ARRAY_SIZE(wm831x_bat_irqs); i++) { irq = platform_get_irq_byname(pdev, wm831x_bat_irqs[i]); irq = wm831x_irq(wm831x, irq); }
| |