lkml.org 
[lkml]   [2012]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix use-after-free of q->root_blkg and q->root_rl.blkg
Hello,

On Thu, Oct 11, 2012 at 10:31:46AM +0900, Jun'ichi Nomura wrote:
> >> - if (ent == &q->root_blkg->q_node)
> >> + if (q->root_blkg && ent == &q->root_blkg->q_node)
> >
> > Can we fix it little differently. Little earlier in the code, we check for
> > if q->blkg_list is empty, then all the groups are gone, and there are
> > no more request lists hence and return NULL.
> >
> > Current code:
> > if (rl == &q->root_rl) {
> > ent = &q->blkg_list;
> >
> > Modified code:
> > if (rl == &q->root_rl) {
> > ent = &q->blkg_list;
> > /* There are no more block groups, hence no request lists */
> > if (list_empty(ent))
> > return NULL;
> > }

Do we need this at all? q->root_blkg being NULL is completely fine
there and the comparison would work as expected, no?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-10-17 02:01    [W:0.130 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site