lkml.org 
[lkml]   [2012]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.
On Tue, 16 Oct 2012 17:27:01 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:

> On Fri, 2012-10-12 at 09:57 +0100, Ian Campbell wrote:
> > > +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma)
> > > +{
> > > + int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > > + struct page **pages = vma ? vma->vm_private_data : NULL;
> >
> > I thought we agreed to keep uses of vm_private_data in the privcmd
> > driver?
> >
> > I think you should just add pages and nr as direct parameters to
> > this function, which is symmetric with the map call.
>
> I had to look at this while rebasing my arm patches, turned out to be
> fairly simple. Feel free to either fold in or badger me for a proper
> commit message.


I made similar change in my tree, except I am not passing vma as its
not needed. I guess you just wanna be consistend with remap, or future
use?

thanks
mukesh




\
 
 \ /
  Last update: 2012-10-16 20:21    [W:0.137 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site