lkml.org 
[lkml]   [2012]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Fix memory leak in binder--version2
From
On Mon, Oct 15, 2012 at 3:52 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Oct 15, 2012 at 07:20:01AM +0000, Tu, Xiaobing wrote:
>> After enabling kmemleak and run monkey, following memleak is reported:
>> unreferenced object 0xeed27f80 (size 64):
>> comm "Binder_8", pid 641, jiffies 4294946341 (age 2275.810s)
>> hex dump (first 32 bytes):
>> 4f dd 00 00 84 7f d2 ee 84 7f d2 ee 01 00 00 00 O...............
>> 00 00 00 00 00 00 00 00 00 aa 4c d7 00 00 00 00 ..........L.....
>> backtrace:
>> [<c184fabc>] kmemleak_alloc+0x3c/0xa0
>> [<c12f391e>] kmem_cache_alloc_trace+0x9e/0x180
>> [<c1668bb5>] binder_thread_write+0xcf5/0x23a0
>> [<c166b091>] binder_ioctl+0x1f1/0x530
>> [<c130dcf6>] do_vfs_ioctl+0x86/0x5e0
>> [<c130e282>] sys_ioctl+0x32/0x60
>> [<c1872e01>] syscall_call+0x7/0xb
>> [<ffffffff>] 0xffffffff
>>
>> The work item in async_todo list is not freed when binder released.
>> Also the async transaction should also be freed in binder_release_work.
>>
>> Signed-off-by: Leon Ma <xindong.ma@intel.com>
>> Signed-off-by: Di Zhang <di.zhang@intel.com>
>> ---
>> drivers/staging/android/binder.c | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> Nice fix, but next time can you at least use scripts/get_maintainer.pl
> to figure out who to send this to? I'll queue it up soon, but it took
> akpm to point me at this for me to notice it.

This patch was just pointer out to me as well. I have a similar fix
queued up at https://android-review.googlesource.com/#/c/43801/ that
is still being tested. It fixes this leak and a theoretical leak of
death notification objects.

--
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-10-16 02:21    [W:1.757 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site