Messages in this thread | | | From | Irina Tirdea <> | Date | Tue, 16 Oct 2012 01:59:06 +0300 | Subject | Re: [PATCH v3 6/8] perf tools: Try to find cross-built objdump path |
| |
>> >> + if (!objdump_path) >> + try_objdump_path(session); > > Please do the test on perf_session_env__lookup_objdump() and handle > errors, i.e. what happens if that strdup/asprintf fails? > > Ok, that is unlikely, but not impossible, but what happens if we don't > find the right objdump? Shouldn't we use ui__error("please install > required objdump" (or a better, more detailed message)? >
My initial intention was to use the default "objdump" in case of any error. On second though, this should not be allowed since the data was recorded on a different architecture. I'll print error messages instead.
Thanks, Irina
| |