lkml.org 
[lkml]   [2012]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 6/6] mfd: Differentiate between u8500 and u9540 TCDM address mapping
Date
On Wednesday 10 October 2012, Lee Jones wrote:
> @@ -2688,7 +2688,11 @@ void __init db8500_prcmu_early_init(void)
> iounmap(tcpm_base);
> }
>
> - tcdm_base = __io_address(U8500_PRCMU_TCDM_BASE);
> + if (cpu_is_u9540())
> + tcdm_base = ioremap_nocache(U8500_PRCMU_TCDM_BASE,
> + SZ_4K + SZ_8K) + SZ_8K;
> + else
> + tcdm_base = __io_address(U8500_PRCMU_TCDM_BASE);
> } else {
> pr_err("prcmu: Unsupported chip version\n");
> BUG();

Would it be possible to get the base out of the device tree and always
map it from there? Adding another dependency on a fixed constant is
just going to make the conversion to multiplatform harder, since it
was decided that device drivers should not have access to platform
header files in the multiplatform case.

Arnd


\
 
 \ /
  Last update: 2012-10-10 21:01    [W:0.103 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site