lkml.org 
[lkml]   [2012]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: CONFIG_EXPERT is a booby trap
On Mon, 1 Oct 2012, Tim Shepard wrote:

> Interestingly, of the 26 configs that use EXPERT in the default
> clause, 15 of them are in drivers/hid (see below).
>
> -Tim Shepard
> shep@alum.mit.edu
>
> - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>
> $ find . -type f -name Kconfig'*' -print | xargs fgrep default | grep EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/hid/Kconfig: default !EXPERT
> ./drivers/media/common/tuners/Kconfig: default y if !EXPERT
> ./drivers/media/common/tuners/Kconfig: default y if EXPERT
> ./drivers/media/dvb/frontends/Kconfig: default y if EXPERT
> ./drivers/media/video/Kconfig: default y if !EXPERT
> ./init/Kconfig: default !EXPERT
> ./lib/Kconfig.debug: default !EXPERT
> ./net/rfkill/Kconfig: default y if !EXPERT
> ./usr/Kconfig: default !EXPERT
> ./usr/Kconfig: default !EXPERT
> ./usr/Kconfig: default !EXPERT
> ./usr/Kconfig: default !EXPERT

I don't think selecting CONFIG_EXPERT should change whether a config
option is enabled or disabled by default, I think it should only change
whether certain options are available for enabling or disabling. These do
need care when fixing, though, and in the above circumstances you may find
that s/EXPERT/EMBEDDED/ is the right change.


\
 
 \ /
  Last update: 2012-10-02 06:21    [W:0.059 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site