lkml.org 
[lkml]   [2012]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] regulator: Add S5M8767A regulator driver
On Mon, Jan 09, 2012 at 05:35:47PM +0900, Sangbeom Kim wrote:

> After delete above functions, Is it right to code like below?

> +static struct regulator_ops s5m8767_buck_ops = {
> + .enable = s5m8767_reg_enable,
> + .disable = s5m8767_reg_disable,
> + .set_suspend_enable = s5m8767_reg_enable,
> + .set_suspend_disable = s5m8767_reg_disable,

No. If your hardware doesn't have this feature your driver shouldn't
pretend it does, and if such a mapping were a good way of implementing
this we'd be better doing it in the core.


\
 
 \ /
  Last update: 2012-01-09 09:45    [from the cache]
©2003-2011 Jasper Spaans