Messages in this thread | | | Date | Mon, 9 Jan 2012 19:04:44 +0100 | From | Joerg Roedel <> | Subject | Re: Incorrect uses of get_driver()/put_driver() |
| |
On Mon, Jan 09, 2012 at 12:35:09PM -0500, Alan Stern wrote: > lib/dma-debug.c:173: drv = get_driver(dev->driver); > lib/dma-debug.c:188: put_driver(drv); > > Joerg, these calls don't seem to do anything, as far as I can tell. > Is there any reason to keep them?
No reason to keep them :) It can be replaced with dev->driver, even reference counting is not needed because only the pointer is kept and never dereferenced.
Joerg
-- AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
| |