Messages in this thread | | | From | Seiji Aguchi <> | Date | Mon, 9 Jan 2012 12:59:51 -0500 | Subject | RE: [RFC][PATCH v4 -next 1/4] Move kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop() |
| |
> >I don't know how to prove something is hardened other than not seeing any >hangs or false reboots on in that piece of code. >
I don't know how we can prove reliability of smp_send_stop() of all archs as well.
Another possible solution is replacing smp_send_stop() with machine_crash_shutdown(). This is a function call stopping other cpus reliably in panic situation so that kdump can work . But, I don't know whether it works in all archs. We need further discussion with Eric for checking this idea is feasible...
I would like to go forward step by step rather than doing tough work at once. I think just moving kmsg_dump() below smp_send_stop() is a good start for improving pstore.
Seiji
| |