lkml.org 
[lkml]   [2012]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] jsm: Fixed EEH recovery error
    Date
    There was an error on the jsm driver that would cause it to be unable to
    recover after a second error is detected.

    At the first error, the device recovers properly:

    [72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
    [72521.485695] EEH: This PCI device has failed 1 times in the last hour:
    ...
    [72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
    [72532.105689] jsm: Port 3 added

    However, at the second error, it cascades until EEH disables the device:

    [72631.229549] Call Trace:
    ...
    [72641.725687] jsm: Port 3 added
    [72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
    [72641.725698] EEH: This PCI device has failed 3 times in the last hour:

    It was caused because the PCI state was not being saved after the first
    restore. Therefore, at the second recovery the PCI state would not be
    restored.

    Signed-off-by: Lucas Kannebley Tavares <lucaskt@linux.vnet.ibm.com>
    Signed-off-by: Breno Leitao <brenohl@br.ibm.com>
    Acked-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
    ---
    drivers/tty/serial/jsm/jsm_driver.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c
    index 7c867a0..7545fe1 100644
    --- a/drivers/tty/serial/jsm/jsm_driver.c
    +++ b/drivers/tty/serial/jsm/jsm_driver.c
    @@ -251,6 +251,7 @@ static void jsm_io_resume(struct pci_dev *pdev)
    struct jsm_board *brd = pci_get_drvdata(pdev);

    pci_restore_state(pdev);
    + pci_save_state(pdev);

    jsm_uart_port_init(brd);
    }
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2012-01-09 14:01    [W:0.019 / U:91.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site