Messages in this thread | | | Date | Mon, 9 Jan 2012 16:54:27 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH v8 3.2.0-rc5 9/9] perf: perf interface for uprobes |
| |
> > > + > > +static int convert_to_perf_probe_point(struct probe_trace_point *tp, > > + struct perf_probe_point *pp) > > +{ > > + pp->function = strdup(tp->symbol); > > + if (pp->function == NULL) > > + return -ENOMEM; > > + pp->offset = tp->offset; > > + pp->retprobe = tp->retprobe; > > + > > + return 0; > > +} > > This function could be used in kprobe_convert_to_perf_probe() too. > In that case, it will be separated as a cleanup from this.
Do you really want this in a separate patch, since it doesnt make too much sense without the uprobes code.
-- Thanks and Regards Srikar
| |