lkml.org 
[lkml]   [2012]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] KVM: fix mov immediate emulation for 64-bit operands
    From
    On Sun, Jan 8, 2012 at 4:08 PM, Avi Kivity <avi@redhat.com> wrote:
    > On 01/08/2012 04:05 PM, Avi Kivity wrote:
    >> >
    >> > Avi, please acknowledge adding OpImm64.
    >>
    >> Yes, OpImm64 is the cleanest IMO.  Note it doesn't even cost us a bit.

    Very well - I'll submit a revised patch later.

    >
    > Note, usually I'd ask for a unit test to accompany the fix, but the
    > current framework only supports testing instructions that have a memroy
    > operand.  So you're off the hook for now, unless you'd like to extend
    > the framework.

    Unfortunately, I don't. I am doing some odd things with KVM that cause
    me to encounter emulator bugs.
    I am likely to submit another patch or two as the emulation code has
    additional "issues" handling EPT violations (especially on non-memory
    operands).

    Regards,
    Nadav
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-08 15:47    [W:0.020 / U:33.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site