Messages in this thread Patch in this message | | | From | Gilad Ben-Yossef <> | Subject | [RFC PATCH v2 3/9] x86: avoid using on_each_cpu hard coded ret value | Date | Sun, 8 Jan 2012 15:32:23 +0200 |
| |
on_each_cpu always returns a hard coded return code of zero.
Removing all tests based on this return value saves run time cycles for compares and code bloat for branches.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Reviewed-by: Michal Nazarewicz <mina86@mina86.com> CC: Thomas Gleixner <tglx@linutronix.de> CC: Ingo Molnar <mingo@redhat.com> CC: "H. Peter Anvin" <hpa@zytor.com> CC: x86@kernel.org --- arch/x86/lib/cache-smp.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c index a3c6688..760f7e1 100644 --- a/arch/x86/lib/cache-smp.c +++ b/arch/x86/lib/cache-smp.c @@ -14,6 +14,7 @@ EXPORT_SYMBOL(wbinvd_on_cpu); int wbinvd_on_all_cpus(void) { - return on_each_cpu(__wbinvd, NULL, 1); + on_each_cpu(__wbinvd, NULL, 1); + return 0; } EXPORT_SYMBOL(wbinvd_on_all_cpus); -- 1.7.0.4
| |