lkml.org 
[lkml]   [2012]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git pull] vfs pile 1
On Sun, Jan 08, 2012 at 11:50:40PM +0000, Al Viro wrote:

> WTF is ext4_symlink() doing in case of long symlinks? Look:
> drop_nlink(inode);
> err = ext4_orphan_add(handle, inode);
> ext4_journal_stop(handle);
> [write symlink body]
> inc_nlink(inode);
> err = ext4_orphan_del(handle, inode);
> oh, I see... The comment above that re deadlocks and inability to do that
> in a single transaction ;-/
>
> OK, try this; that's equivalent to what they are doing and will not WARN_ON();
> I hadn't checked other filesystems for similar tricks yet, so this has a good
> chance of being incomplete.

... and sure enough, ext3 has the same piece of fun.


\
 
 \ /
  Last update: 2012-01-09 00:57    [W:0.056 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site