Messages in this thread | | | Date | Sun, 8 Jan 2012 09:53:38 -0800 | Subject | Re: [PATCH v2012.2] fs: symlink restrictions on sticky directories | From | Kees Cook <> |
| |
On Sun, Jan 8, 2012 at 3:44 AM, Matthew Wilcox <matthew@wil.cx> wrote: > On Sat, Jan 07, 2012 at 10:55:48AM -0800, Kees Cook wrote: >> v2012.2: >> - Change sysctl mode to 0600, suggested by Ingo Molnar. >> - Rework CONFIG logic to split code from default behavior. >> - Renamed sysctl to have a "sysctl_" prefix, suggested by Andrew Morton. > > All the sysctl / CONFIG logic seems very complex. Why not make it > a module parameter instead? It can be easily changed at boot time > (specify kernel.insecure_symlinks=1 on the kernel command line) and, > with a mode of 0600, can be modified at runtime too.
Well, I'll still need a CONFIG for the code itself, and the normal way to tweak kernel operation is via sysctls, so I'd rather not switch to cmdline options.
-Kees
-- Kees Cook ChromeOS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |