lkml.org 
[lkml]   [2012]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions
    Hi Joe,

    On 01/05/2012 06:38 PM, Joe Perches wrote:
    > On Thu, 2012-01-05 at 15:28 +0200, Kalle Valo wrote:
    >
    >> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
    > []
    >> +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...)
    > []
    >> + ath6kl_printk(KERN_DEBUG, "%pV", &vaf);
    > [
    >> diff --git a/drivers/net/wireless/ath/ath6kl/debug.h b/drivers/net/wireless/ath/ath6kl/debug.h
    > []
    >> +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...);
    >
    > You need to add
    >
    > __printf(2, 3)
    >
    > to the prototype.
    >
    > If it's not there, the printf formats and arguments aren't verified.
    > %pV could do the wrong/bad things.

    Nice, I'll add that to v3. Thanks again.

    Kalle


    \
     
     \ /
      Last update: 2012-01-06 09:17    [W:0.025 / U:30.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site