lkml.org 
[lkml]   [2012]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next] fs: fix fs/fs-writeback.c build error
On Thu, Jan 5, 2012 at 4:18 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> In linux-next, fs/fs-writeback.c no longer #includes <linux/buffer_head.h>,
> which #included <linux/pagemap.h>, so add that latter header file to
> <linux/writeback.h> to fix the build error:
>
> fs/fs-writeback.c:510:11: error: 'PAGE_CACHE_SHIFT' undeclared (first use in this function)

I would actually suggest:

- move the whole MIN_WRITEBACK_PAGES #define from the header file to
fs/writeback.c (why expose such a random #define to outside users that
have nothing to do with it?)

- make sure that fs/fs-writeback.c has that pagemap.h #include.

There's no reason why <linux/writeback.h> should include filemap.h per
se, and there is no reason why it should expose some internal chunking
#define to anybody else.

Wu?

Linus


\
 
 \ /
  Last update: 2012-01-07 00:05    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site