Messages in this thread | | | Date | Thu, 5 Jan 2012 10:17:04 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v2012.1] fs: symlink restrictions on sticky directories |
| |
* Kees Cook <keescook@chromium.org> wrote:
> @@ -1495,6 +1496,15 @@ static struct ctl_table fs_table[] = { > #endif > #endif > { > + .procname = "protected_sticky_symlinks", > + .data = &protected_sticky_symlinks, > + .maxlen = sizeof(int), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = &zero, > + .extra2 = &one, > + },
Small detail:
Might make sense to change the .mode to 0600, to make it harder for unprivileged attack code to guess whether this protection (and the resulting audit warning to the administrator) is enabled on a system or not.
It can be probed, but only at the cost of generating a warning.
Likewise, distros should set /etc/sysctl.conf to 0600 as well, for similar reasons.
Thanks,
Ingo
| |