[lkml]   [2012]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHv3 1/3] gpio: add a driver for the Synopsys DesignWare APB GPIO block
On Wed, Jan 04, 2012 at 11:21:33AM -0700, Grant Likely wrote:
> On Mon, Jan 02, 2012 at 01:25:00PM +0000, Mark Brown wrote:

> > > v2: - use Rob Herring's irqdomain in generic irq chip patches
> > > - use reg property to indicate bank index
> > > - support irqs on both edges based on LinusW's u300 driver

> > Put stuff like this after the ---, it shouldn't end up in git history.

> I disagree. Keeping the revision history in the git commit is
> actually quite useful when trying to figure out which version of a
> patch actually got applied. I'm asking patch authors to keep it above
> the ---

I wouldn't be completely opposed to keeping *a* version in, the thing
that gets me is the entire changelog - it gets really noisy quite
quickly and the history for the patch ends up dominating the changelog.
The older entries normally have vanishingly little utility without the
changes (and where they do should normally be written into the actual
description of the change) and all you need to know which version got
applied is information on the most recent revision.

But TBH you could also get the version by just putting it in the subject
outside of [ ] so it doesn't get stripped.

 \ /
  Last update: 2012-01-05 06:49    [W:0.044 / U:3.896 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site