Messages in this thread | | | Date | Thu, 5 Jan 2012 20:40:06 -0800 | Subject | Re: [PATCH block:for-3.3/core] cfq: merged request shouldn't jump to a different cfqq | From | Tejun Heo <> |
| |
Hello,
On Thu, Jan 5, 2012 at 8:15 PM, Shaohua Li <shaohua.li@intel.com> wrote: > don't know. I don't think a tweak for merge impacts isolation so much. > For rotate disk, request size hasn't impact to request cost, so this > doesn't impact isolation. Even for ssd, big size request is more > efficient to dispatch. And we already have breakage of fairness for SSD, > such as no idle.
I'm not saying they shouldn't be merged but the decision should be elevator's. Block core shouldn't decide it for the elevator. So, whether cross cfqq merge is a good idea or not is mostly irrelevant in this thread.
Thanks.
-- tejun
| |