Messages in this thread | | | Date | Thu, 5 Jan 2012 14:06:45 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH v5 7/8] mm: Only IPI CPUs to drain local pages if they exist |
| |
On Thu, 5 Jan 2012 16:17:39 +0000 Mel Gorman <mel@csn.ul.ie> wrote:
> mm: page allocator: Guard against CPUs going offline while draining per-cpu page lists > > While running a CPU hotplug stress test under memory pressure, I > saw cases where under enough stress the machine would halt although > it required a machine with 8 cores and plenty memory. I think the > problems may be related.
When we first implemented them, the percpu pages in the page allocator were of really really marginal benefit. I didn't merge the patches at all for several cycles, and it was eventually a 49/51 decision.
So I suggest that our approach to solving this particular problem should be to nuke the whole thing, then see if that caused any observeable problems. If it did, can we solve those problems by means other than bringing the dang things back?
| |