Messages in this thread | | | Date | Thu, 5 Jan 2012 09:52:14 -0800 | Subject | Re: [PATCH 4/5] x86: efi: add basic error handling | From | Olof Johansson <> |
| |
On Thu, Jan 5, 2012 at 3:21 AM, Matt Fleming <matt.fleming@intel.com> wrote: > On Tue, 2012-01-03 at 09:11 -0800, Olof Johansson wrote: >> It's not perfect, but way better than before. Mark efi_enabled as false in >> case of error and at least stop dereferencing pointers that are known to >> be invalid. >> >> The only significant missing piece is the lack of undoing the >> memblock_reserve of the memory that efi marks as in use. On the other >> hand, it's not a large amount of memory, and leaving it unavailable for >> system use should be the safer choice anyway. >> >> Signed-off-by: Olof Johansson <olof@lixom.net> >> --- >> arch/x86/platform/efi/efi.c | 89 ++++++++++++++++++++++++++++-------------- >> 1 files changed, 59 insertions(+), 30 deletions(-) > > Seems straight forward and better than what was there previously. Have > you tested this error handling?
Not much, since the systems I have won't boot if there's an error (even if graceful) and I didn't have a console with earlyprintk support until yesterday. I'll beat on it a bit this afternoon but it should be OK as it is.
Thanks,
-Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |