lkml.org 
[lkml]   [2012]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices)
    On Thu, Jan 5, 2012 at 9:37 AM, Mauro Carvalho Chehab
    <mchehab@infradead.org> wrote:
    >
    > For the media drivers, we've already fixed it, at the V4L side:
    > -EINVAL doesn't mean that an ioctl is not supported anymore.
    > I think that such fix went into Kernel 3.1.

    Ok, I'm happy to hear that the thing should be fixed. My grepping
    still found a fair amount of EINVAL returns both in code and in the
    Documentation subdirectory for media ioctls, but it really was just
    grepping with a few lines of context, so I didn't look closer at the
    semantics. I was just looking for certain patterns (ie grepping for
    "EINVAL" near ioctl or ENOIOCTLCMD etc) that I thought might indicate
    problem spots, and the media subdirectory had a lot of them.

    Can you test the patch with some media capture apps (preferably with
    the obvious fix for the problem that Paulo already pointed out -
    although that won't actually matter until some block driver starts
    using ENOIOCTLCMD there, so even the unfixed patch should mostly work
    for testing)?

    Linus


    \
     
     \ /
      Last update: 2012-01-05 18:49    [W:0.021 / U:1.764 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site