[lkml]   [2012]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 3/3] perf top: Don't update total_period on process_sample
    From: Arnaldo Carvalho de Melo <>

    It will be recalculated at __hists__output_resort, to take into account
    filters possibly applied by the TUI, etc.

    Since we do the percent math only for those entries that will appear on
    the TUI instead of for _all_ the entries at decay time, updating it for
    each sample makes the entries seem to decay faster when using the
    navigation keys (since the screen will be refreshed), as we're not
    coalescing the entries that are being batched to be merged at next
    resort/decay time, but considering their periods.

    Bug introduced in 743eb86.

    Reported-by: Ingo Molnar <>
    Cc: David Ahern <>
    Cc: Frederic Weisbecker <>
    Cc: Mike Galbraith <>
    Cc: Paul Mackerras <>
    Cc: Peter Zijlstra <>
    Cc: Stephane Eranian <>
    Signed-off-by: Arnaldo Carvalho de Melo <>
    tools/perf/builtin-top.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
    index 4f81eeb..d89dec9 100644
    --- a/tools/perf/builtin-top.c
    +++ b/tools/perf/builtin-top.c
    @@ -235,7 +235,6 @@ static struct hist_entry *perf_evsel__add_hist_entry(struct perf_evsel *evsel,
    if (he == NULL)
    return NULL;

    - evsel->hists.stats.total_period += sample->period;
    hists__inc_nr_events(&evsel->hists, PERF_RECORD_SAMPLE);
    return he;

     \ /
      Last update: 2012-01-05 18:11    [W:0.021 / U:40.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site