Messages in this thread | | | Subject | Re: [PATCH v2 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions | From | Joe Perches <> | Date | Thu, 05 Jan 2012 08:38:09 -0800 |
| |
On Thu, 2012-01-05 at 15:28 +0200, Kalle Valo wrote:
Hey Kalle.
> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c [] > +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...) [] > + ath6kl_printk(KERN_DEBUG, "%pV", &vaf); [ > diff --git a/drivers/net/wireless/ath/ath6kl/debug.h b/drivers/net/wireless/ath/ath6kl/debug.h [] > +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...);
You need to add
__printf(2, 3)
to the prototype.
If it's not there, the printf formats and arguments aren't verified. %pV could do the wrong/bad things.
| |