lkml.org 
[lkml]   [2012]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/5] xen/pciback: Move the PCI_DEV_FLAGS_ASSIGNED ops to the "[un|]bind"
    Date
    operation instead of doing it per guest creation/disconnection. Without
    this we could have potentially unloaded the vf driver from the
    xen pciback control even if the driver was binded to the xen-pciback.
    This will hold on to it until the user "unbind"s the PCI device using
    SysFS.

    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    ---
    drivers/xen/xen-pciback/pci_stub.c | 2 ++
    drivers/xen/xen-pciback/xenbus.c | 2 --
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
    index 0ce0dc6..d66328e 100644
    --- a/drivers/xen/xen-pciback/pci_stub.c
    +++ b/drivers/xen/xen-pciback/pci_stub.c
    @@ -114,6 +114,7 @@ static void pcistub_device_release(struct kref *kref)
    xen_pcibk_config_free_dyn_fields(psdev->dev);
    xen_pcibk_config_free_dev(psdev->dev);

    + psdev->dev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED;
    pci_dev_put(psdev->dev);

    kfree(psdev);
    @@ -366,6 +367,7 @@ static int __devinit pcistub_init_device(struct pci_dev *dev)
    dev_dbg(&dev->dev, "reset device\n");
    xen_pcibk_reset_device(dev);

    + dev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED;
    return 0;

    config_release:
    diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
    index 0755259..474d52e 100644
    --- a/drivers/xen/xen-pciback/xenbus.c
    +++ b/drivers/xen/xen-pciback/xenbus.c
    @@ -241,7 +241,6 @@ static int xen_pcibk_export_device(struct xen_pcibk_device *pdev,
    goto out;

    dev_dbg(&dev->dev, "registering for %d\n", pdev->xdev->otherend_id);
    - dev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED;
    if (xen_register_device_domain_owner(dev,
    pdev->xdev->otherend_id) != 0) {
    dev_err(&dev->dev, "device has been assigned to another " \
    @@ -281,7 +280,6 @@ static int xen_pcibk_remove_device(struct xen_pcibk_device *pdev,
    }

    dev_dbg(&dev->dev, "unregistering for %d\n", pdev->xdev->otherend_id);
    - dev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED;
    xen_unregister_device_domain_owner(dev);

    xen_pcibk_release_pci_dev(pdev, dev);
    --
    1.7.7.4


    \
     
     \ /
      Last update: 2012-01-05 01:51    [W:3.023 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site