lkml.org 
[lkml]   [2012]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions
    From
    Date
    On Thu, 2012-01-05 at 01:09 +0200, Kalle Valo wrote:
    > That way it's possible to not export debug_mask outside the upcoming
    > ath6kl_core.ko and that makes it easier to ath6kl_core.ko in the
    > following patch.
    []
    > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
    []
    > diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
    []
    > +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...)
    > +{
    > + va_list args;
    > +
    > + if (!(debug_mask & mask))
    > + return;
    > +
    > + va_start(args, fmt);
    > + ath6kl_printk(KERN_DEBUG, fmt, &args);

    Passing a va_list as an argument?
    I believe this doesn't work.
    I think you'll need to add and use:

    struct va_format vaf;

    vaf.fmt = fmt;
    vaf.va = &args;

    ath6kl_printk(KERN_DEBUG, "%pV", &vaf);





    \
     
     \ /
      Last update: 2012-01-05 00:43    [W:0.024 / U:92.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site