Messages in this thread | | | Date | Wed, 4 Jan 2012 21:56:23 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH] include: crash_dump.h: Add elf.h header |
| |
On Wed, Jan 04, 2012 at 12:28:05PM -0800, Andrew Morton wrote: > The patch is the right thing to do, however I'm rather concerned about > the potential for introducing build breakage so late in 3.2. > > Can we leave this unfixed in 3.2 and fix it in 3.2.1? Or put a > #include elf.h into arch/arm/kernel/setup.c for 3.2?
arch/arm/kernel/setup.c doesn't need either of these includes. The reason I didn't want to just remove the include and magic the error away is because of the obvious fragility of the current situation, which really needs solving.
As this is the only report of this breakage, I'm inclined to go with your first suggestion: leave it unfixed in 3.2 and fix it in -stable once it's been in visible for a bit.
| |