Messages in this thread Patch in this message | | | Date | Wed, 4 Jan 2012 07:20:23 -0800 | From | tip-bot for Namhyung Kim <> | Subject | [tip:perf/core] perf session: Remove impossible condition check |
| |
Commit-ID: 29c9862f1b818bf4caa4c48a30dbe5f25c84ee08 Gitweb: http://git.kernel.org/tip/29c9862f1b818bf4caa4c48a30dbe5f25c84ee08 Author: Namhyung Kim <namhyung@gmail.com> AuthorDate: Wed, 28 Dec 2011 00:35:48 +0900 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Tue, 3 Jan 2012 14:35:02 -0200
perf session: Remove impossible condition check
The 'size' cannot be 0 because it was set to 8 on the above line in case it was 0 and never changed.
Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1325000151-4463-1-git-send-email-namhyung@gmail.com Signed-off-by: Namhyung Kim <namhyung@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/session.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index cc5e6be..b5ca255 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1015,8 +1015,7 @@ more: } } - if (size == 0 || - (skip = perf_session__process_event(self, &event, tool, head)) < 0) { + if ((skip = perf_session__process_event(self, &event, tool, head)) < 0) { dump_printf("%#" PRIx64 " [%#x]: skipping unknown header type: %d\n", head, event.header.size, event.header.type); /*
| |