Messages in this thread | | | From | Grant Likely <> | Date | Tue, 31 Jan 2012 14:51:53 -0700 | Subject | Re: [PATCH 1/3] platform: add common resource requesting and mapping helper |
| |
On Tue, Jan 31, 2012 at 2:15 PM, Wolfram Sang <w.sang@pengutronix.de> wrote: > >> > I am not sure using 'platform_devm_request_and_ioremap' and later using >> > plain 'devm_*' functions (without platform_-prefix) is less confusing. >> > The alternative would be to check which helper functions also use >> > 'struct resource' and if they do checks on that. If all do that, you >> > would have the simple rule, that you only need to check yourself if you >> > access it yourself. >> >> The reason I suggested the wrapper is that then the driver code doesn't need >> to fart around with the res pointer at all. It reduces boilerplate in platform >> drivers which I think is a good thing. > > I do understand your motivation and fully agree with what you are aiming for > (that's exactly why I implemented devm_request_and_ioremap()). > > This patch is a micro-optimization, though, and won't cut it IMHO. I still have > issues with only one platform_devm_* and all the rest being devm_* (without > platform_). Things might look better, if we'd for example also have > platform_devm_request_irq() or something similar. That might be an approach > where we can play around with and see what is left to do. Or, if other > approaches might be more elegant. > > To discuss that, try things, etc, I'd simply like to have a bit more time. If > we are accepting the first iteration right away, and people let run their > coccinelle-scripts based on that, it might get annoying to change that a second > time, I'd think.
Okay, I'm willing to sit-tight on this for a bit.
g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |