lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] lib: add NO_GENERIC_PCI_IOPORT_MAP
    On Mon, Jan 30, 2012 at 08:04:32PM +0000, Arnd Bergmann wrote:
    > On Monday 30 January 2012, Michael S. Tsirkin wrote:
    > > >
    > > > +/*
    > > > + * Create a virtual mapping cookie for a port on a given PCI device.
    > > > + * Do not call this directly, it exists to make it easier for architectures
    > > > + * to override.
    > > > + */
    > > > +#ifdef CONFIG_NO_GENERIC_PCI_IOPORT_MAP
    > > > +extern void __iomem *__pci_ioport_map(struct pci_dev *dev, unsigned long port,
    > > > + unsigned int nr);
    > > > +#else
    > > > +static inline void __iomem *__pci_ioport_map(struct pci_dev *dev,
    > > > + unsigned long port, unsigned int nr)
    > > > +{
    > > > + return ioport_map(port, nr);
    > > > +}
    > > > +#endif
    > > >
    > > > Arnd
    > >
    > > It would be nicer in that it would
    > > make the kernel a bit smaller for generic architectures
    > > but this would need to go into a separate header:
    > > it depends on io.h and io.h depends on pci_iomap.h.
    >
    > Adding extra dependencies is not good here, I agree.
    > Maybe a better solution is to use a macro instead of an inline
    > function then:
    >
    > #define __pci_ioport_map(dev, port, nr) ioport_map(port, nr)
    >
    > In general, macros should be avoided, but I think it's the
    > best tradeoff in this case.
    >
    > Arnd

    OK, I did exactly that. Thanks!


    \
     
     \ /
      Last update: 2012-01-31 22:21    [W:0.020 / U:1.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site