lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: Disambiguate kernel message

* Arun Sharma <asharma@fb.com> wrote:

> + printk(KERN_INFO "TCP: too many orphaned "
> "sockets\n");

> + printk(KERN_INFO "TCP: out of memory. "
> + "Consider tuning tcp_mem\n");

> + printk(KERN_INFO "TCP: out of memory. "
> + "Consider tuning tcp_mem\n");
> + if (too_many_orphans && net_ratelimit())
> + printk(KERN_INFO "TCP: too many orphaned sockets\n");

A small detail: please don't line break user-visible strings in
mid sentence. Just keep the line long. Makes it much easier to
search for the source of a kernel message:

git grep "TCP: too many orphaned sockets"

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-01-31 20:47    [W:0.978 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site