Messages in this thread | | | Date | Tue, 31 Jan 2012 20:44:50 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] net: Disambiguate kernel message |
| |
* Arun Sharma <asharma@fb.com> wrote:
> + printk(KERN_INFO "TCP: too many orphaned " > "sockets\n");
> + printk(KERN_INFO "TCP: out of memory. " > + "Consider tuning tcp_mem\n");
> + printk(KERN_INFO "TCP: out of memory. " > + "Consider tuning tcp_mem\n"); > + if (too_many_orphans && net_ratelimit()) > + printk(KERN_INFO "TCP: too many orphaned sockets\n");
A small detail: please don't line break user-visible strings in mid sentence. Just keep the line long. Makes it much easier to search for the source of a kernel message:
git grep "TCP: too many orphaned sockets"
Thanks,
Ingo
| |