lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] smsc95xx: add macaddr module parameter
    On Tue, 31 Jan 2012 18:20:33 +0100
    Danny Kukawka <danny.kukawka@bisect.de> wrote:

    > Added smsc95xx.macaddr module parameter to allow the user to
    > change the MAC address on boot if there was no MAC on the EEPROM.

    NAK. Please see the discussion on this and ifconfig hw for other devices.

    In summary - make the device refuse to ifconfig up without a valid
    address, allow it to come into existance without a valid address and then
    use ifconfig.


    Your patch also seems to break if there are several attached to a board.


    \
     
     \ /
      Last update: 2012-01-31 18:29    [W:0.020 / U:0.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site