Messages in this thread | | | Date | Tue, 31 Jan 2012 17:27:31 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] smsc95xx: add macaddr module parameter |
| |
On Tue, 31 Jan 2012 18:20:33 +0100 Danny Kukawka <danny.kukawka@bisect.de> wrote:
> Added smsc95xx.macaddr module parameter to allow the user to > change the MAC address on boot if there was no MAC on the EEPROM.
NAK. Please see the discussion on this and ifconfig hw for other devices.
In summary - make the device refuse to ifconfig up without a valid address, allow it to come into existance without a valid address and then use ifconfig.
Your patch also seems to break if there are several attached to a board.
| |