Messages in this thread | | | Date | Tue, 31 Jan 2012 15:41:36 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH] sysfs: Update the name hash when renaming sysfs entries |
| |
On 01/31/2012 03:40 PM, Eric W. Biederman wrote: > > This fixes a bug introduced with sysfs name hashes where renaming a > network device appears to succeed but silently makes the sysfs files for > that network device inaccessible. > > In at least one configuration this bug has stopped networking from > coming up during boot. > > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
It works for me. Thanks.
Tested-by: Jiri Slaby <jslaby@suse.cz>
> --- > fs/sysfs/dir.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c > index ea64d01..dd3779c 100644 > --- a/fs/sysfs/dir.c > +++ b/fs/sysfs/dir.c > @@ -872,6 +872,7 @@ int sysfs_rename(struct sysfs_dirent *sd, > > dup_name = sd->s_name; > sd->s_name = new_name; > + sd->s_hash = sysfs_name_hash(sd->s_ns, sd->s_name); > } > > /* Move to the appropriate place in the appropriate directories rbtree. */
-- js suse labs
| |