lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [v7 1/8] smp: introduce a generic on_each_cpu_mask function
    From
    On Mon, Jan 30, 2012 at 11:52 PM, Andrew Morton
    <akpm@linux-foundation.org> wrote:
    > On Sun, 29 Jan 2012 14:24:16 +0200
    > Gilad Ben-Yossef <gilad@benyossef.com> wrote:
    >
    >> On Thu, Jan 26, 2012 at 12:01 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
    >> > on_each_cpu_mask calls a function on processors specified by
    >> > cpumask, which may or may not include the local processor.
    >> >
    >> > You must not call this function with disabled interrupts or
    >> > from a hardware interrupt handler or from a bottom half handler.
    >> >
    >> > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
    >> > Reviewed-by: Christoph Lameter <cl@linux.com>
    >> > CC: Chris Metcalf <cmetcalf@tilera.com>
    >> ...
    >> > ---
    >> > __include/linux/smp.h | __ 22 ++++++++++++++++++++++
    >> > __kernel/smp.c __ __ __ __| __ 29 +++++++++++++++++++++++++++++
    >> > __2 files changed, 51 insertions(+), 0 deletions(-)
    >> >
    >>
    >>
    >> Milton made the very sensible comment that while adding on_each_cpu() in the
    >> arch generic code and removing the two arch specific instances from tile and arm
    >> in separate patches is good for review, it will break bisect.
    >>
    >> He suggested I squash  them into a single commit when it goes in.
    >>
    >> Since you picked the patch set into linux-mm, will now be a good time for that?
    >
    > I can fold the patches together - I do that all the time.
    >
    > Please identify exactly whcih patches you're referring to here.
    >
    > arm-move-arm-over-to-generic-on_each_cpu_mask and
    > tile-move-tile-to-use-generic-on_each_cpu_mask should be folded into
    > smp-introduce-a-generic-on_each_cpu_mask-function, yes?

    Yes. Thank you.

    Gilad

    --
    Gilad Ben-Yossef
    Chief Coffee Drinker
    gilad@benyossef.com
    Israel Cell: +972-52-8260388
    US Cell: +1-973-8260388
    http://benyossef.com

    "Unfortunately, cache misses are an equal opportunity pain provider."
    -- Mike Galbraith, LKML
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-31 07:35    [W:0.023 / U:31.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site